[libvirt-ci PATCH] lcitool: Set make parallelism dynamically

Erik Skultety eskultet at redhat.com
Mon May 11 08:20:39 UTC 2020


On Thu, May 07, 2020 at 06:53:12PM +0200, Andrea Bolognani wrote:
> We're about to make some changes to lcitool that would make it
> more annoying to get access to the number of install-time vCPUs
> from 'lcitool update', so let's use getconf instead.
> 
> As a side effect, this also copes better with the situation where
> the builder was installed with a certain number of vCPUs but the
> amount has since been modified.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/playbooks/update/templates/bashrc.j2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guests/playbooks/update/templates/bashrc.j2 b/guests/playbooks/update/templates/bashrc.j2
> index 8775864..05a86a1 100644
> --- a/guests/playbooks/update/templates/bashrc.j2
> +++ b/guests/playbooks/update/templates/bashrc.j2
> @@ -4,7 +4,7 @@ export MAKE="{{ paths.make }}"
>  export NINJA="{{ paths.ninja }}"
>  export PYTHON="{{ paths.python }}"
>  
> -export MAKEFLAGS="-j{{ install_vcpus|int + 1 }}"
> +export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)"

By the way, do you happen to know where the _NPROCESSORS_ONLN came from? I mean
the only trace of it was the system config constant _SC_NPROCESSORS_ONLN which
the getconf one will be translated to, I was just confused where shorter name
came from, since it's not documented in any of the man pages (or it may be, but
I don't have that specific man page installed).

Erik




More information about the libvir-list mailing list