[libvirt PATCH 0/6] Add ability to create mediated devices in libvirt

[Daniel P. Berrangé]

On Mon, May 11, 2020 at 03:28:02PM +0200, Michal Privoznik wrote:
> On 4/30/20 11:42 PM, Jonathon Jongsma wrote:
> > This is the first portion of an effort to support persistent mediated devices
> > with libvirt. This first series simply enables creating and destroying
> > non-persistent mediated devices via the virNodeDeviceCreateXML() and
> > virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] provides the backend
> > implementation.
> > 
> > [1] https://github.com/mdevctl/mdevctl
> > 
> > Jonathon Jongsma (6):
> >    nodedev: factor out nodeDeviceHasCapability()
> >    nodedev: add support for mdev attributes
> >    nodedev: refactor nodeDeviceFindNewDevice()
> >    nodedev: store mdev UUID in mdev caps
> >    nodedev: add mdev support to virNodeDeviceCreateXML()
> >    nodedev: add mdev support to virNodeDeviceDestroy()
> > 
> >   docs/schemas/nodedev.rng             |   6 +

docs/formatnode.html.in needs some documentation and examples

> >   libvirt.spec.in                      |   3 +
> >   m4/virt-external-programs.m4         |   3 +
> >   src/conf/node_device_conf.c          |  59 ++++-
> >   src/conf/node_device_conf.h          |   3 +
> >   src/conf/virnodedeviceobj.c          |  34 +++
> >   src/conf/virnodedeviceobj.h          |   3 +
> >   src/libvirt_private.syms             |   3 +
> >   src/node_device/node_device_driver.c | 326 ++++++++++++++++++++++++---
> >   src/node_device/node_device_udev.c   |   5 +-
> >   src/util/virmdev.c                   |  12 +
> >   src/util/virmdev.h                   |  11 +
> >   12 files changed, 425 insertions(+), 43 deletions(-)
> > 
> 
> 
> Codewise, this looks good. I will let Erik review the semantics of creating
> mdevs.
> 
> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

This is notably lacking any unit test coverage, so is not validating the
RNG schema or the XML parser or conversion of XML to mdevctl args. I think
that needs fixing before we accept it.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|