[PATCH V3 1/5] cpu_map: Introduce ARM cpu models

[Jiri Denemark]

On Wed, Apr 22, 2020 at 15:11:16 +0800, ZhengZhenyu wrote:
> Introduce vendors and some commonly used models
> for ARM arch, these will be used for virConnectionGetCapabilities
> for ARM CPUs.
> 
> Signed-off-by: Zhenyu Zheng <zhengzhenyulixi at gmail.com>
> ---
>  src/cpu_map/Makefile.inc.am       |  7 +++++++
>  src/cpu_map/arm_Falkor.xml        | 16 ++++++++++++++++
>  src/cpu_map/arm_Kunpeng-920.xml   | 24 ++++++++++++++++++++++++
>  src/cpu_map/arm_ThunderX299xx.xml | 16 ++++++++++++++++
>  src/cpu_map/arm_cortex-a53.xml    | 16 ++++++++++++++++
>  src/cpu_map/arm_cortex-a57.xml    | 15 +++++++++++++++
>  src/cpu_map/arm_cortex-a72.xml    | 15 +++++++++++++++
>  src/cpu_map/arm_vendors.xml       | 14 ++++++++++++++
>  src/cpu_map/index.xml             | 15 +++++++++++++++
>  9 files changed, 138 insertions(+)
>  create mode 100644 src/cpu_map/arm_Falkor.xml
>  create mode 100644 src/cpu_map/arm_Kunpeng-920.xml
>  create mode 100644 src/cpu_map/arm_ThunderX299xx.xml
>  create mode 100644 src/cpu_map/arm_cortex-a53.xml
>  create mode 100644 src/cpu_map/arm_cortex-a57.xml
>  create mode 100644 src/cpu_map/arm_cortex-a72.xml
>  create mode 100644 src/cpu_map/arm_vendors.xml

This patch should be moved just before the last one to make sure libvirt
can be built after each patch.

> 
> diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am
> index be64c9a0d4..93c2b19ddf 100644
> --- a/src/cpu_map/Makefile.inc.am
> +++ b/src/cpu_map/Makefile.inc.am
> @@ -2,7 +2,14 @@
>  
>  cpumapdir = $(pkgdatadir)/cpu_map
>  cpumap_DATA = \
> +    cpu_map/arm_cortex-a53.xml \

This line is indented with 4 spaces while it should start with a tab
instead.

> +	cpu_map/arm_cortex-a57.xml \
> +	cpu_map/arm_cortex-a72.xml \
>  	cpu_map/arm_features.xml \
> +	cpu_map/arm_Kunpeng-920.xml \
> +	cpu_map/arm_ThunderX299xx.xml \
> +	cpu_map/arm_Falkor.xml \
> +	cpu_map/arm_vendors.xml \
>  	cpu_map/index.xml \
>  	cpu_map/ppc64_vendors.xml \
>  	cpu_map/ppc64_POWER7.xml \
> diff --git a/src/cpu_map/arm_Falkor.xml b/src/cpu_map/arm_Falkor.xml
> new file mode 100644
> index 0000000000..902ed2b6ba
> --- /dev/null
> +++ b/src/cpu_map/arm_Falkor.xml
> @@ -0,0 +1,16 @@
> +<cpus>
> +  <model name='Falkor'>
> +    <vendor name='Qualcomm'/>
> +    <pvr value='0xc00'/>
> +    <feature name="fp"/>
> +    <feature name="asimd"/>
> +    <feature name="evtstrm"/>
> +    <feature name="aes"/>
> +    <feature name="pmull"/>
> +    <feature name="sha1"/>
> +    <feature name="sha2"/>
> +    <feature name="crc32"/>
> +    <feature name="cpuid"/>
> +    <feature name="asimdrdm"/>

What is the purpose of the feature list here when you don't parse them
anywhere?

> +  </model>
> +</cpus>

Jirka