[libvirt PATCH] qemu: reject readonly attribute for virtiofs

Peter Krempa pkrempa at redhat.com
Wed May 13 09:51:50 UTC 2020


On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote:
> On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote:
> > > This is not yet supported by virtiofsd.
> > > 
> > > Fixes #23
> > 
> > Please include the full URL here:
> > 
> >   https://gitlab.com/libvirt/libvirt/-/issues/23

While I definitely don't like gitlab's URIs ...

> Using the '#23' format is the recommended way. GitLab UI will
> turn it into a hyperlink, and automatically close the mentioned
> issue.

... just mentioning #23 is useless for users looking at the git repo
directly (not through the web-ui) or if we at some point decide to
abandon gitlab.

Even if gitlab can't handle the automation of closing the comment when
the URI is mentioned I don't see why we should make it harder for users
who want to stay away from the browser as much as possible.




More information about the libvir-list mailing list