[libvirt-java PATCH 5/6] gitlab: introduce CI jobs testing git master & distro libvirt

[Andrea Bolognani]

On Tue, 2020-05-12 at 10:51 +0100, Daniel P. Berrangé wrote:
> +.dist_build_job_template: &dist_build_job_definition
> +  image: $CI_REGISTRY_IMAGE/ci-$NAME:latest
> +  stage: builds
> +  script:
> +    - ant build jar docs
> +    - if test "$NAME" != "centos-8" ; then ant test ; fi

I don't like the fact that you hardcode the name of a specific target
in the build steps. We should do something similar to what I've
implemented for libosinfo instead: in the script, use

  - if test "$TESTS" != "skip"; then ant test; fi

so then, in the job definitions for CentOS 8, you can do

  centos-8-dist-build:
    <<: *dist_build_job_definition
    variables:
      NAME: centos-8
      TESTS: skip

The actual variable name and value can be different, of course, but
you get the idea.

> +fedora-32-git-build:
> +  <<: *git_build_job_definition
> +  variables:
> +    NAME: fedora-32

I understand that CentOS 8 is clearly not a good candidate for this
job, but can we use something a little more long-term than Fedora to
reduce churn? Ubuntu 20.04, for example.

That would not give us coverage of the RPM build job, but honestly I
don't think there's much of a chance of that breaking because of
changes in *libvirt* git.

Everything else looks good.

-- 
Andrea Bolognani / Red Hat / Virtualization