[PATCH 02/21] qemuMonitorJSONParseKeywords: remove constant argument

Eric Blake eblake at redhat.com
Fri May 15 18:19:41 UTC 2020


On 5/15/20 10:27 AM, Peter Krempa wrote:
> There's just one caller that always passes '1'.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_monitor_json.c | 17 +++++------------
>   1 file changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 505b31a78a..66422a8489 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -604,16 +604,15 @@ qemuMonitorJSONParseKeywordsFree(int nkeywords,
>   /*
>    * Takes a string containing a set of key=value,key=value,key...
>    * parameters and splits them up, returning two arrays with
> - * the individual keys and values. If allowEmptyValue is nonzero,
> - * the "=value" part is optional and if a key with no value is found,
> + * the individual keys and values.
> + * The "=value" part is optional and if a key with no value is found,
>    * NULL is be placed into corresponding place in retvalues.

While you are touching this, s/is be placed into/will be placed into the/

With that,
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list