[PATCH 08/15] testQEMUSchemaValidate(Command): Allow skipping validation of deprecated fields

[Ján Tomko]

On a Wednesday in 2020, Peter Krempa wrote:
>Some test cases are used to validate interactions with old qemu. We need
>to skip validation of deprecation with those once it will be added.
>
>In case of commands which were already replaced by code based on
>capabilities we can skip the full validation once the command is
>removed.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> tests/qemublocktest.c        | 14 +++++++-------
> tests/qemumonitorjsontest.c  |  3 ++-
> tests/qemumonitortestutils.c |  5 ++++-
> tests/testutilsqemuschema.c  | 17 +++++++++++++++--
> tests/testutilsqemuschema.h  |  3 +++
> 5 files changed, 31 insertions(+), 11 deletions(-)
>
>@@ -508,16 +515,22 @@ testQEMUSchemaValidate(virJSONValuePtr obj,
>  * -1 if it does not and -2 if there is a problem with the schema or with
>  *  internals.
>  *
>+ * @alllowRemoved should generally be used only if it's certain that there's a

*allow

>+ * replacement of @command in place.
>+ *
>  * @debug is filled with information regarding the validation process
>  */
> int
> testQEMUSchemaValidateCommand(const char *command,
>                               virJSONValuePtr arguments,
>                               virHashTablePtr schema,

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200519/d69c2121/attachment-0001.sig>