[PATCH] virDomainNetDefParseXML: Fix error message for unknown value of //mac/@type

Michal Privoznik mprivozn at redhat.com
Mon Nov 2 19:55:46 UTC 2020


In v6.6.0-rc1~124 we've introduced a new mechanism for MAC
addresses for ESX: ignore all checks (type='static') that libvirt
or ESX would do (and possibly fail) for specified MAC address.
Accepted values for the @type attribute are "generated" and
"static". But the error message mentions a different attribute.

Fixes 454e5961abf40c14f8b6d7ee216229e68fd170bf
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1892130
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---

Pushed as trivial.

 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f4f017cf83..b47f43afd9 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -12248,7 +12248,7 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt,
         int tmp;
         if ((tmp = virDomainNetMacTypeTypeFromString(macaddr_type)) <= 0) {
             virReportError(VIR_ERR_XML_ERROR,
-                           _("invalid mac address check value: '%s'. Valid "
+                           _("invalid mac address type value: '%s'. Valid "
                              "values are \"generated\" and \"static\"."),
                            macaddr_type);
             goto error;
-- 
2.26.2




More information about the libvir-list mailing list