[libvirt PATCH 18/25] vircgroup: no need to use PID in virCgroupEnableMissingControllers

Pavel Hrdina phrdina at redhat.com
Tue Nov 3 12:41:30 UTC 2020


This function is relevant only with cgroups v1 where it creates
hierarchy for controllers that are not managed by systemd. PID is used
to detect a placement of current process but in this situation we are
building the hierarchy for already known placement.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/util/vircgroup.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 81aa3ee791..2c1d6f9f01 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1112,14 +1112,13 @@ virCgroupNewDetectMachine(const char *name,
 
 static int
 virCgroupEnableMissingControllers(char *path,
-                                  pid_t pidleader,
                                   int controllers,
                                   virCgroupPtr *group)
 {
     g_autoptr(virCgroup) parent = NULL;
     char *offset = path;
 
-    if (virCgroupNew(pidleader,
+    if (virCgroupNew(-1,
                      "/",
                      controllers,
                      &parent) < 0)
@@ -1213,10 +1212,8 @@ virCgroupNewMachineSystemd(const char *name,
         return -2;
     }
 
-    if (virCgroupEnableMissingControllers(path, pidleader,
-                                          controllers, &newGroup) < 0) {
+    if (virCgroupEnableMissingControllers(path, controllers, &newGroup) < 0)
         return -1;
-    }
 
     if (virCgroupAddProcess(newGroup, pidleader) < 0) {
         virErrorPtr saved;
-- 
2.26.2




More information about the libvir-list mailing list