[libvirt PATCH 21/25] vircgroup: drop @create from virCgroupNewDomainPartition

Pavel Hrdina phrdina at redhat.com
Tue Nov 3 12:41:33 UTC 2020


All callers pass true.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/util/vircgroup.c     | 5 +----
 src/util/vircgrouppriv.h | 1 -
 tests/vircgrouptest.c    | 4 ++--
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 00967ea5fa..1e18b84b54 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -969,7 +969,6 @@ int
 virCgroupNewDomainPartition(virCgroupPtr partition,
                             const char *driver,
                             const char *name,
-                            bool create,
                             virCgroupPtr *group)
 {
     g_autofree char *grpname = NULL;
@@ -993,7 +992,7 @@ virCgroupNewDomainPartition(virCgroupPtr partition,
      * a group for driver, is to avoid overhead to track
      * cumulative usage that we don't need.
      */
-    if (virCgroupMakeGroup(partition, newGroup, create,
+    if (virCgroupMakeGroup(partition, newGroup, true,
                            VIR_CGROUP_MEM_HIERACHY) < 0) {
         return -1;
     }
@@ -1278,7 +1277,6 @@ virCgroupNewMachineManual(const char *name,
     if (virCgroupNewDomainPartition(parent,
                                     drivername,
                                     name,
-                                    true,
                                     &newGroup) < 0)
         return -1;
 
@@ -2836,7 +2834,6 @@ int
 virCgroupNewDomainPartition(virCgroupPtr partition G_GNUC_UNUSED,
                             const char *driver G_GNUC_UNUSED,
                             const char *name G_GNUC_UNUSED,
-                            bool create G_GNUC_UNUSED,
                             virCgroupPtr *group G_GNUC_UNUSED)
 {
     virReportSystemError(ENXIO, "%s",
diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h
index 7248bc1d35..77e01519b0 100644
--- a/src/util/vircgrouppriv.h
+++ b/src/util/vircgrouppriv.h
@@ -123,7 +123,6 @@ int virCgroupNewPartition(const char *path,
 int virCgroupNewDomainPartition(virCgroupPtr partition,
                                 const char *driver,
                                 const char *name,
-                                bool create,
                                 virCgroupPtr *group)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5);
 
diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c
index 0dd5e3f0b4..1baa71e61c 100644
--- a/tests/vircgrouptest.c
+++ b/tests/vircgrouptest.c
@@ -434,7 +434,7 @@ static int testCgroupNewForPartitionDomain(const void *args G_GNUC_UNUSED)
         return -1;
     }
 
-    if ((rv = virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo", true, &domaincgroup)) != 0) {
+    if ((rv = virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo", &domaincgroup)) != 0) {
         fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv);
         return -1;
     }
@@ -475,7 +475,7 @@ static int testCgroupNewForPartitionDomainEscaped(const void *args G_GNUC_UNUSED
         return -1;
     }
 
-    if ((rv = virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.foo", true, &domaincgroup)) != 0) {
+    if ((rv = virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.foo", &domaincgroup)) != 0) {
         fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv);
         return -1;
     }
-- 
2.26.2




More information about the libvir-list mailing list