[PATCH 4/9] qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a backup

Peter Krempa pkrempa at redhat.com
Wed Nov 4 13:05:02 UTC 2020


If we don't have a consistent chain of bitmaps for the backup to proceed
we'd report VIR_ERR_INVALID_ARG error code, which makes it hard to
decide whether an incremental backup makes even sense.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_backup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index 5376d9485d..d0c852cf80 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -206,7 +206,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd,
     if (!qemuBlockBitmapChainIsValid(dd->domdisk->src,
                                      dd->backupdisk->incremental,
                                      blockNamedNodeData)) {
-        virReportError(VIR_ERR_INVALID_ARG,
+        virReportError(VIR_ERR_CHECKPOINT_INCONSISTENT,
                        _("missing or broken bitmap '%s' for disk '%s'"),
                        dd->backupdisk->incremental, dd->domdisk->dst);
         return -1;
-- 
2.26.2




More information about the libvir-list mailing list