[PATCH] domain_conf: make virDomainDiskSetSource() void

Ján Tomko jtomko at redhat.com
Thu Nov 5 15:59:10 UTC 2020


On a Thursday in 2020, Matt Coleman wrote:
>The function only returns zero or aborts, so it might as well be void.
>This has the added benefit of simplifying the code that calls it.
>
>Signed-off-by: Matt Coleman <matt at datto.com>
>---
> src/conf/domain_conf.c   |  3 +--
> src/conf/domain_conf.h   |  3 +--
> src/libxl/libxl_driver.c |  6 ++----
> src/libxl/xen_xl.c       |  3 +--
> src/libxl/xen_xm.c       | 13 ++++---------
> src/lxc/lxc_controller.c | 13 ++-----------
> src/vbox/vbox_common.c   |  6 +-----
> src/vmx/vmx.c            | 36 ++++++++++++------------------------
> src/vz/vz_sdk.c          |  4 ++--
> 9 files changed, 26 insertions(+), 61 deletions(-)
>

Nice cleanup.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201105/4189d96b/attachment-0001.sig>


More information about the libvir-list mailing list