[PATCH 12/28] domain_conf: make virDomainControllerDriverFormat() void

Matt Coleman mcoleman at datto.com
Fri Nov 6 03:32:48 UTC 2020


This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt at datto.com>
---
 src/conf/domain_conf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 88125683d1..d8a6f89695 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -25918,7 +25918,7 @@ virDomainDiskDefFormat(virBufferPtr buf,
 }
 
 
-static int
+static void
 virDomainControllerDriverFormat(virBufferPtr buf,
                                 virDomainControllerDefPtr def)
 {
@@ -25944,8 +25944,6 @@ virDomainControllerDriverFormat(virBufferPtr buf,
     virDomainVirtioOptionsFormat(&driverBuf, def->virtio);
 
     virXMLFormatElement(buf, "driver", &driverBuf, NULL);
-
-    return 0;
 }
 
 
@@ -26092,8 +26090,7 @@ virDomainControllerDefFormat(virBufferPtr buf,
         }
     }
 
-    if (virDomainControllerDriverFormat(&childBuf, def) < 0)
-        return -1;
+    virDomainControllerDriverFormat(&childBuf, def);
 
     virDomainDeviceInfoFormat(&childBuf, &def->info, flags);
 
-- 
2.27.0





More information about the libvir-list mailing list