[PATCH 15/28] domain_conf: make virDomainIOMMUDefFormat() void

Matt Coleman mcoleman at datto.com
Fri Nov 6 03:32:51 UTC 2020


This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt at datto.com>
---
 src/conf/domain_conf.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d716db596a..edfaf7c8af 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -29372,7 +29372,7 @@ virDomainDefIothreadShouldFormat(virDomainDefPtr def)
 }
 
 
-static int
+static void
 virDomainIOMMUDefFormat(virBufferPtr buf,
                         const virDomainIOMMUDef *iommu)
 {
@@ -29407,8 +29407,6 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
                       virDomainIOMMUModelTypeToString(iommu->model));
 
     virXMLFormatElement(buf, "iommu", &attrBuf, &childBuf);
-
-    return 0;
 }
 
 
@@ -30384,9 +30382,8 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
             return -1;
     }
 
-    if (def->iommu &&
-        virDomainIOMMUDefFormat(buf, def->iommu) < 0)
-        return -1;
+    if (def->iommu)
+        virDomainIOMMUDefFormat(buf, def->iommu);
 
     if (def->vsock &&
         virDomainVsockDefFormat(buf, def->vsock) < 0)
-- 
2.27.0





More information about the libvir-list mailing list