Libvirt Open Source Contribution

[Ryan Gahagan]

We've also been having some troubles actually getting ninja and meson to
run properly. Our team has one member on MacOS, one on Ubuntu 18.04, and
one working on a remote server (Ubuntu again) without sudo privileges. We
want to be able to run ninja test to properly test and clean our code as we
make pull requests, but it's been very difficult to get set up.

The Ubuntu aptitude store has an outdated version of meson that doesn't
actually run properly, and the pip3 version is up to date but then the
build dependencies are left unresolved. These dependencies are also by
default not actually in the aptitude store either, nor can they easily be
mass installed via homebrew (to our knowledge). Even after manually
configuring aptitude to find the links to all the dependencies of the
project, manually installing meson and ninja, and installing the
dependencies, we are still left with an error that says "XDR is required
for remote driver". Most of our team cannot even reach this point, as any
of the earlier steps is not reproducible due to either the environment not
having the correct tooling or lacking sufficient administrator privilege to
execute them.

All of our code we've written thus far has relied entirely upon the CI to
build the project for us, which is not a particularly efficient workflow
due to the time it takes for CI to finish. How can we get ninja test (and
other build tools) to actually run on our machines? Do you have any
additional instructions that we may be able to use outside of the
CONTRIBUTING.rst file?

-Ryan Gahagan

On Sat, Nov 7, 2020 at 12:04 PM Barrett J Schonefeld <bschoney at utexas.edu>
wrote:

> Michal,
>
> We've struggled with the email system so far. You may have seen when we
> submitted a chain of 65 patches when we meant to send only the last commit.
> We tested this by sending it to ourselves first but must have made a
> mistake when submitting to libvir-list.
>
> We submitted an initial patch for issue-11, which was rejected because
> Ryan emailed the patch, but I was CCed. I am working on getting my computer
> set up to submit this patch myself.
>
> Additionally, we submitted a patch for issue-16 (from Ryan Gahagan), and
> we feel confident we did this correctly (even received a confirmation
> email). However, we have not seen the patch posted on the forum nor have we
> received any email that the patch was rejected. Is it possible it has not
> been posted because we left outstanding questions in the patch?
>
> Best regards,
> Barrett Schonefeld
>
> On Fri, Nov 6, 2020 at 2:03 AM Michal Prívozník <mprivozn at redhat.com>
> wrote:
>
>> On 11/5/20 10:04 PM, Barrett J Schonefeld wrote:
>> > Hey folks,
>> >
>> > We appreciate the feedback, and we've used this to complete some
>> initial
>> > work on issue 11.
>> >
>> > We started with small changes in src/util, and we submitted them via
>> > email (following these guidelines on submitting patches
>> > <https://libvirt.org/submitting-patches.html>) to ensure we are on the
>> > right path.
>> >
>> > We do not see the patch we submitted via email showing up in the
>> > threads, and we are wondering if we are submitting incorrectly or if
>> the
>> > patch goes through some approval process before appearing in the
>> threads.
>> >
>> > Best regards,
>> > Barrett Schonefeld
>>
>> So I checked the moderator's queue and there are no patches stuck, so
>> probably it is something else. Did you see any error when 'git
>> send-email'-ing the patches? When I was setting up my machine I used to
>> send patches just to me to verify send-email is working and only then I
>> tried to send patches to the list.
>>
>> Also, are you sure you (the sender) are subscribed to the list?
>> Generally, if you aren't then list won't forward your e-mails/patches.
>>
>> Michal
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201108/89d3bc07/attachment-0001.htm>