[PATCH] convert char pointers to use g_autofree

Ján Tomko jtomko at redhat.com
Mon Nov 9 16:23:42 UTC 2020


The commit summary is too broad. A prefix to say which part of the
codebase is touched would be nice:
   util: convert char pointers to use g_autofree

On a Friday in 2020, Ryan Gahagan wrote:
>From: bschoney <bschoney at utexas.edu>
>
>additional conversions to the GLib API in src/util per issue #11.
>

>Please let me know if there are additional changes I should make in the files updated so far.
>I intend to submit work on additional files, and I want to be sure the changes so far are correct.
>

The changes itself look good.

>Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11
>
>Signed-off-by: bschoney <bschoney at utexas.edu>

Can you change both the author field and the sign-off to contain your
full name? I would fix it up before merging the patch, but touching
these two fields is off-limits to me.

Something like
   git config --global user.name "Your Name"
to set it in ~/.gitconfig and
   git commit --amend --reset-author -s
should do the trick.


>---
> src/util/vircgroupv1.c  |  3 +--
> src/util/virhostcpu.c   |  4 +---
> src/util/virlockspace.c |  6 ++----
> src/util/virmacmap.c    |  3 +--
> src/util/virresctrl.c   | 25 ++++++++-----------------
> src/util/virsysinfo.c   |  9 +++------
> 6 files changed, 16 insertions(+), 34 deletions(-)
>

With the full name added:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201109/32a88e61/attachment-0001.sig>


More information about the libvir-list mailing list