[PATCH v4 0/7] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate

[Hao Wang]

I quite agree with you and will modify that in my next realeases. Thanks for your suggestion!


On 2020/11/10 9:34, Han Han wrote:
> 
> 
> On Sat, Nov 7, 2020 at 5:54 PM Hao Wang <wanghao232 at huawei.com <mailto:wanghao232 at huawei.com>> wrote:
> 
>     V3 -> V4:
>     define flags to unsigned int
>     fix some compile warnings
> 
>     V2 -> V3:
>     reorganize patchset to fix compile warning
> 
>     V1 -> V2:
>     replace QEMU_JOB_ASYNC with QEMU_JOB_QUERY
> 
> 
>     Sometimes domain's memory dirty rate is expected by user in order to
>     decide whether it's proper to be migrated out or not.
> 
>     We have already completed the QEMU part of the capability:
>     https://patchew.org/QEMU/1600237327-33618-1-git-send-email-zhengchuan@huawei.com/
>     And this serial of patches introduce the corresponding LIBVIRT part --
>     DomainGetDirtyRateInfo API and corresponding virsh api -- "getdirtyrate".
> 
> 
>     instructions:
>     bash# virsh getdirtyrate --help
>       NAME
>         getdirtyrate - Get a vm's memory dirty rate
> 
> I think it is better to name the virsh cmd as 'domgetdirtyrate' or 'domdirtyrate' because
> the most of virsh cmds for getting the info of VM have the prefix dom.
>