[libvirt] [PATCH v2 02/13] virsh: Add logical CPU IDs completion for nodecpustats command

[Michal Privoznik]

On 11/10/20 10:50 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>   tools/virsh-completer-host.c | 31 +++++++++++++++++++++++++++++++
>   tools/virsh-completer-host.h |  4 ++++
>   tools/virsh-host.c           |  1 +
>   3 files changed, 36 insertions(+)
> 
> diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c
> index 339390aa00..685fa23fd4 100644
> --- a/tools/virsh-completer-host.c
> +++ b/tools/virsh-completer-host.c
> @@ -136,3 +136,34 @@ virshCellnoCompleter(vshControl *ctl,
>   
>       return g_steal_pointer(&tmp);
>   }
> +
> +
> +char **
> +virshCpuCompleter(vshControl *ctl,
> +                  const vshCmd *cmd G_GNUC_UNUSED,
> +                  unsigned int flags)

With so many CPU completers I think this should include Node in its 
name, e.g. virshNodeCpuCompleter() so that it's obvious it's completing 
host's CPUs.

Michal