[libvirt PATCH] conf: Use unsigned long long for timer frequency

Martin Kletzander mkletzan at redhat.com
Wed Nov 11 21:47:34 UTC 2020


On Wed, Nov 11, 2020 at 06:00:52PM +0100, Jiri Denemark wrote:
>Although the code in qemuProcessStartValidateTSC works as if the
>timer frequency was already unsigned long long (by using an appropriate
>temporary variable), the virDomainTimerDef structure actually defines
>frequency as unsigned long, which is not guaranteed to be 64b.
>
>Fixes support for frequencies higher than 2^32 - 1 on 32b systems.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>

Yeah, sure, why not.  I mean:

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>---
> src/conf/domain_conf.c  | 6 +++---
> src/conf/domain_conf.h  | 2 +-
> src/qemu/qemu_command.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>

Tests when?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201111/18cd9f75/attachment-0001.sig>


More information about the libvir-list mailing list