[PATCH 8/8] tools: virsh: Reset error when keepalive registration fails

Peter Krempa pkrempa at redhat.com
Thu Nov 12 13:43:05 UTC 2020


We try to enable keepalive oportunistically. If it's not supported by
the connection driver and it was not explicitly requested we keep the
error object set and can report it in some cases accidentally:

--- stdout ---
TEST: /home/pipo/libvirt/tests/virsh-self-test
      !                                        1   FAILED
--- stderr ---
error: parameter 'target' of command 'attach-disk' must be listed before optional parameters
error: this function is not supported by the connection driver: virConnectSetKeepAlive
-------

Clear the stored libvirt error.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tools/virsh.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virsh.c b/tools/virsh.c
index 954778b626..a6bfbbbb87 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -176,6 +176,7 @@ virshConnect(vshControl *ctl, const char *uri, bool readonly)
         }
         vshDebug(ctl, VSH_ERR_INFO, "%s",
                  _("Failed to setup keepalive on connection\n"));
+        vshResetLibvirtError();
     }

  cleanup:
-- 
2.28.0




More information about the libvir-list mailing list