[PATCH 0/8] tools: vsh: Fix validation of command parameter lists

[Ján Tomko]

On a Thursday in 2020, Peter Krempa wrote:
>Recent patch:
>
>https://www.redhat.com/archives/libvir-list/2020-November/msg00555.html
>
>passes build check but then virsh complains when started that the
>command list is wrong.
>
>Fix it by moving the check to the appropriate place.
>
>You can use the above patch as reproducer.
>
>Peter Krempa (8):
>  tools: vsh: Unexport vshCmddefHelp
>  tools: vshCmddefCheckInternals: Add parameter name to error message
>  tools: vshCmddefCheckInternals: Port mandatory options check from
>    vshCmddefOptParse
>  tools: cmdSelfTest: Drop misleading comment
>  tools: vshCmddefOptParse: Remove 'optional' command validation
>  tools: vshCmddefHelp: Don't call vshCmddefOptParse
>  tools: vshCmddefOptParse: Remove return value
>  tools: virsh: Reset error when keepalive registration fails
>
> tools/virsh.c |   1 +
> tools/vsh.c   | 108 +++++++++++++++++++++-----------------------------
> tools/vsh.h   |   1 -
> 3 files changed, 47 insertions(+), 63 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201112/39973a23/attachment-0001.sig>