[PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

[Nikolay Shirokovskiy]

On 13.11.2020 10:24, Peter Krempa wrote:
> On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote:
>> This is successor to [1] but I changed the subject as in the review the patch
>> 'qemu: sync backing chain update in virDomainGetBlockJobInfo' was not
>> considered good one from design POV. However I think the basic patch is helpful
>> to address similar issues. Look at [*] for example, there it allows to sync
>> backing chains during query block stats.
>>
>> In discussion of [1] I stated that first patch will also allow to get rid of
>> stale block job events on reconnection to qemu. But this will require
>> additional work actually so with this patch series stale events are still
>> present. And in the discussion it was also mentioned by Peter that stale events
>> are not harmful for legacy blockjobs code. I also removed previous attempts to
>> eliminate some of stale events.
>>
>> I still keep patch for virDomainGetBlockJobInfo. May be in comparsion to [*]
>> the approach the patch takes will look not so bad :)
>>
>> [1] First version of the patch series
>> https://www.redhat.com/archives/libvir-list/2020-October/msg01133.html
> 
> Please allow for longer review time. I'm stuffed with other work and
> also as I've pointed out last time I'm not very in favor of modifying
> the old block job code since it's being phased out.
> 
> I still suggest the client application is fixed to use the events and
> stop polling virDomainGetBlockJobInfo.
> 

Of course, take your time, we all have our duties.

Note that there is new case in "[PATCH v2 09/10] qemu: fix race on legacy block 
completion and quering stats" that is similar to case in                        
virDomainGetBlockJobInfo. AFAIU modern blockjobs are also affected. 

Nikolay