[PATCH libvirt v2 11/11] node_device: detecting mdev_types capability on ap_matrix device

[Boris Fiuczynski]

On 11/12/20 10:08 PM, Jonathon Jongsma wrote:
>> diff --git a/tests/nodedevschemadata/ap_matrix_mdev_types.xml
>> b/tests/nodedevschemadata/ap_matrix_mdev_types.xml new file mode
>> 100644 index 00000000..0ca83680
>> --- /dev/null
>> +++ b/tests/nodedevschemadata/ap_matrix_mdev_types.xml
>> @@ -0,0 +1,14 @@
>> +<device>
>> +  <name>ap_matrix</name>
>> +  <path>/sys/devices/vfio_ap/matrix</path>
>> +  <parent>computer</parent>
>> +  <capability type='ap_matrix'>
>> +    <capability type='mdev_types'>
>> +      <type id='vfio_api-passthrough'>
> nit: I guess this is just an arbitrary string representing an mdev
> type, but I would guess that you intended it to say vfio_ap- instead
> of vfio_api-?

Your guess is correct. It must read: 'vfio_ap-passthrough'
Good catch!

> 
>> +        <name>VFIO AP Passthrough Device</name>
>> +        <deviceAPI>vfio-ap</deviceAPI>
>> +        <availableInstances>65536</availableInstances>
>> +      </type>
>> +    </capability>
>> +  </capability>
>> +</device>
>> diff --git a/tests/nodedevxml2xmltest.c b/tests/nodedevxml2xmltest.c
>> index dc8cb04f..a2321d13 100644
>> --- a/tests/nodedevxml2xmltest.c
>> +++ b/tests/nodedevxml2xmltest.c
>> @@ -128,6 +128,7 @@ mymain(void)
>>       DO_TEST("ap_card07");
>>       DO_TEST("ap_07_0038");
>>       DO_TEST("ap_matrix");
>> +    DO_TEST("ap_matrix_mdev_types");
>>       DO_TEST("mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad");
>>   
>>       return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
> 
> Reviewed-by: Jonathon Jongsma<jjongsma at redhat.com>
> 
Thanks, Jonathon!

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294