[PATCH 2/6] qemu: conf: Clarify default of "vnc_tls_x509_verify"

Ján Tomko jtomko at redhat.com
Fri Nov 13 15:43:32 UTC 2020


On a Friday in 2020, Michal Privoznik wrote:
>On 11/13/20 4:01 PM, Peter Krempa wrote:
>>If both "vnc_tls_x509_verify" and "default_tls_x509_verify" are missing
>>from the config file the client certificate validation is disabled. VNC
>>provides a layer of authentication so client certificate validation is
>>not strictly required.
>>
>>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>>---
>>  src/qemu/qemu.conf | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
>>index 6f9d940477..f40963ce48 100644
>>--- a/src/qemu/qemu.conf
>>+++ b/src/qemu/qemu.conf
>>@@ -119,7 +119,8 @@
>>  # CA in the vnc_tls_x509_cert_dir (or default_tls_x509_cert_dir).
>>  #
>>  # If this option is not supplied, it will be set to the value of
>>-# "default_tls_x509_verify".
>>+# "default_tls_x509_verify". If "default_tls_x509_verify" is not supplied either
>
>No native speaker, but perhaps s/either/neither/? Applies for next 
>patches too.
>

Not a native speaker either, but your suggested substitution sounds
weirder.

Jano

>>+# the default is "0".
>>  #
>>  #vnc_tls_x509_verify = 1
>>
>
>Michal
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201113/3d246319/attachment-0001.sig>


More information about the libvir-list mailing list