[PATCH 3/4] qemuxml2argvtest: Increase timeout on macOS

[Michal Privoznik]

On 11/8/20 10:24 PM, Roman Bolshakov wrote:
> The test takes 100+ seconds if all test suite is run with meson and 45+
> seconds if it's run directly. According to the output of sample tool,
> most of the time (~72 seconds) is spent in poll():
> 
> Sort by top of stack, same collapsed (when >= 5):
>          poll  (in libsystem_kernel.dylib)                         72396
>          tiny_free_no_lock  (in libsystem_malloc.dylib)             1726
>          tiny_malloc_should_clear  (in libsystem_malloc.dylib)      1671
>          free_tiny  (in libsystem_malloc.dylib)                     1287
>          tiny_free_list_add_ptr  (in libsystem_malloc.dylib)        1258
>          tiny_malloc_from_free_list  (in libsystem_malloc.dylib)    1256
> 
> Closes https://gitlab.com/libvirt/libvirt/-/issues/58
> Signed-off-by: Roman Bolshakov <r.bolshakov at yadro.com>
> ---
>   tests/meson.build | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 8decdfa20c..3b77a211bb 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -571,7 +571,13 @@ foreach data : tests
>       ],
>       export_dynamic: true,
>     )
> -  test(data['name'], test_bin, env: tests_env)
> +  if data['name'] == 'qemuxml2argvtest' and host_machine.system() == 'darwin'
> +    timeout = 180
> +  else
> +    # default meson timeout
> +    timeout = 30
> +  endif
> +  test(data['name'], test_bin, env: tests_env, timeout: timeout)
>   endforeach
>   
>   
> 

I think the last time I wanted to increase the timeout I was told that 
it is machine specific and since I know my machine the best I should 
use: meson test --timeout-multiplier=X

Do you need this for the next cirrus patch? If so I think we should just 
add --timeout-multiplier= there.

Michal