[libvirt PATCH 08/11] remote_driver: remove unreachable cleanup code

Peter Krempa pkrempa at redhat.com
Mon Nov 16 16:05:43 UTC 2020


On Mon, Nov 16, 2020 at 16:38:55 +0100, Pavel Hrdina wrote:
> In the cleanup section @info_ret will always be NULL.

The two instances of 'info_ret' are actually completely distinct
variables of distinct types. That's quite sneaky and the commit message
is deceiving.


> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/remote/remote_driver.c | 18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)

If you split the commit:

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list