[PATCH 1/2] hyperv: XML parsing of storage volumes

[Matt Coleman]

> On Nov 19, 2020, at 12:01 PM, Laine Stump <laine at redhat.com> wrote:
> 
> On 11/19/20 8:38 AM, Daniel P. Berrangé wrote:
>> On Wed, Nov 18, 2020 at 01:48:24PM -0500, Matt Coleman wrote:
>>> +#define HYPERV_MAX_IDE_CONTROLLERS 2
>> Is it really possible to have 2 IDE controllers ?
> 
> 
> I know nothing about hyperv, but qemu does allow multiple IDE controllers, and I even once wrote patches to support it, but then we (or maybe it was just "me"?) decided that allowing lots of IDE disks would just be encouraging people to use the oldest, slowest type of disk in large configurations that would most benefit from going to the trouble of getting the proper virtio drivers installed in the guest.
> 
> 
> So in the end, the qemu driver in libvirt only supports a single IDE controller, and only if it is built into the basic machinetype. That won't prevent any other driver from supporting multiple IDE controllers, but I would think twice about doing it.

Hyper-V's UI presents it as two separate controllers that support two 
devices each, but I checked from within the guest and the drives are 
all attached to a single PIIX4 controller.

I'll rework this commit.

Thanks for the feedback, Laine and Daniel!

-- 
Matt