[PATCH 4/4] ci: Run test suite on macOS

Michal Privoznik mprivozn at redhat.com
Fri Nov 20 07:10:57 UTC 2020


On 11/13/20 8:08 PM, Andrea Bolognani wrote:
> On Fri, 2020-11-13 at 16:58 +0100, Michal Privoznik wrote:
>> On 11/8/20 10:24 PM, Roman Bolshakov wrote:
>>> -    - if test "$(uname)" = "FreeBSD"; then ninja -C build dist; fi
>>> -    - if test "$(uname)" = "Darwin"; then ninja -C build && ninja -C build install; fi
>>> +    - ninja -C build dist
>>
>> If we go with --timeout-multiplier= as I'm suggesting in 3/4 then this
>> can't be ninja, but meson. I'm not sure what the whole point of 'ninja'
>> is at this point, sorry.
> 
> ninja is the low-level tool, so in some cases (notably running the
> test suite) having meson call ninja instead of invoking the latter
> directly can enable additional features.

And I guess that's my problem with it. The --timeout-multiplier= is 
argument of meson, but if I want to run a single threaded build (useful 
if I mess up something in a header file that's included from everywhere) 
there's no way to pass "-j1" to meson and I have to use ninja. But guess 
what, ninja doesn't accept --timeout-multiplier (nor does its -h output 
suggest something of that kind). I'd understand if one was "user 
friendly" interface of the other, but that doesn't seem to be the case.
I guess I'm annoyed with having to use different tool each time.

Michal




More information about the libvir-list mailing list