[PATCH] virDomainAuthorizedSSHKeysSet: Use uint for @nkeys

Daniel P. Berrangé berrange at redhat.com
Mon Nov 23 12:21:51 UTC 2020


On Mon, Nov 23, 2020 at 01:15:28PM +0100, Michal Privoznik wrote:
> When introducing the API I've mistakenly used 'int' type for
> @nkeys argument which does nothing more than tells the API how
> many items there are in @keys array. Obviously, negative values
> are not expected and therefore 'unsigned int' should have been
> used.
> 
> Reported-by: Daniel P. Berrangé <berrange at redhat.com>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  include/libvirt/libvirt-domain.h | 2 +-
>  src/driver-hypervisor.h          | 2 +-
>  src/libvirt-domain.c             | 4 ++--
>  src/qemu/qemu_driver.c           | 2 +-
>  src/remote/remote_driver.c       | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list