[PATCH 0/2] hyperv: storage volume XML changes

[Daniel P. Berrangé]

On Wed, Nov 18, 2020 at 01:48:23PM -0500, Matt Coleman wrote:
> Here's a GitLab MR if you'd prefer to review it there:
> https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits
> 
> Matt Coleman (2):
>   hyperv: XML parsing of storage volumes
>   schema: add support for Windows file paths and device names

Side-point....


Looking at these patches makes me quite aware of the lack of unit
test coverage. The native <-> XML conversions are one of the places
we find most benefit from unit testing, as it catches many regrssions
we would otherwise introduce.

Traditionally we would have 1 text file containing the hypervisor
native representation, and one containing the XML representation.
The unit tests would load the former, generate the XML and then
compare to the expected XML.

This is potentially complicated in the hyperv driver as IIUC
there's no real config file containing the native hyperv repr.

Is there any convenient way we can serialize the

    Msvm_ComputerSystem
    Msvm_VirtualSystemSettingData
    Msvm_ProcessorSettingData
    Msvm_MemorySettingData

classes to a text file format, suc that we can later load
them from a unit test ?



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|