[PATCH v3 0/2] hyperv: storage volume XML changes

Matt Coleman mcoleman at datto.com
Mon Nov 23 17:39:51 UTC 2020


Changes since v2:
* raise an error if the parent device cannot be located
* correct the disk count and use constants instead of magic numbers

Here's a GitLab MR if you'd prefer to review it there:
https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits

This link shows a diff between v2 and v3:
https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/diffs?diff_id=126400840&start_sha=6c5a3dfc2bf2f13c0d9765f00b53b15043693517

Matt Coleman (2):
  hyperv: XML parsing of storage volumes
  schema: add support for Windows file paths and device names

 docs/schemas/basictypes.rng                   |   2 +-
 docs/schemas/domaincommon.rng                 |   5 +-
 src/hyperv/hyperv_driver.c                    | 425 +++++++++++++++++-
 src/hyperv/hyperv_driver.h                    |   5 +
 src/hyperv/hyperv_private.h                   |   2 +
 src/hyperv/hyperv_wmi.c                       |  45 ++
 src/hyperv/hyperv_wmi.h                       |   8 +
 src/hyperv/hyperv_wmi_classes.h               |  19 +
 src/hyperv/hyperv_wmi_generator.input         | 134 ++++++
 .../disk-hyperv-physical.xml                  |  17 +
 .../disk-hyperv-virtual.xml                   |  17 +
 .../disk-hyperv-physical.xml                  |  23 +
 .../disk-hyperv-virtual.xml                   |  23 +
 tests/genericxml2xmltest.c                    |   2 +
 14 files changed, 724 insertions(+), 3 deletions(-)
 create mode 100644 tests/genericxml2xmlindata/disk-hyperv-physical.xml
 create mode 100644 tests/genericxml2xmlindata/disk-hyperv-virtual.xml
 create mode 100644 tests/genericxml2xmloutdata/disk-hyperv-physical.xml
 create mode 100644 tests/genericxml2xmloutdata/disk-hyperv-virtual.xml

-- 
2.27.0





More information about the libvir-list mailing list