[PATCH 2/7] qemu: migration: Remove TODO about implementing NBD for TUNNELLED migration

Peter Krempa pkrempa at redhat.com
Tue Nov 24 13:58:57 UTC 2020


Our streams are not the best transport for migration data and we support
TLS for security now. It's unlikely that there will be enough motivation
to add a new migration protocol to tunnell NBD too.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_migration.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index fef0be63a1..85f3c4ccee 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2244,10 +2244,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriverPtr driver,
             }
         }

-        /* TODO support NBD for TUNNELLED migration */
-        if (flags & VIR_MIGRATE_TUNNELLED) {
-            VIR_WARN("NBD in tunnelled migration is currently not supported");
-        } else {
+        if (!(flags & VIR_MIGRATE_TUNNELLED)) {
             cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
             priv->nbdPort = 0;
         }
-- 
2.28.0




More information about the libvir-list mailing list