[libvirt PATCH v3 10/10] cpu_map: Define and enable Snowridge model

[Jiri Denemark]

On Mon, Nov 23, 2020 at 15:14:33 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
> ---
>  src/cpu_map/index.xml                         |  1 +
>  src/cpu_map/meson.build                       |  1 +
>  src/cpu_map/x86_Snowridge.xml                 | 71 +++++++++++++++++++
>  .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_4.1.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_5.0.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_5.1.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_5.2.0.x86_64.xml    |  1 +
>  18 files changed, 88 insertions(+)
>  create mode 100644 src/cpu_map/x86_Snowridge.xml
> 
...
> diff --git a/src/cpu_map/x86_Snowridge.xml b/src/cpu_map/x86_Snowridge.xml
> new file mode 100644
> index 0000000000..c0b94834ce
> --- /dev/null
> +++ b/src/cpu_map/x86_Snowridge.xml
> @@ -0,0 +1,71 @@
> +<cpus>
> +  <model name='Snowridge'>
> +    <decode host='on' guest='on'/>
> +    <signature family='6' model='134'/>

Sigh. This is the same signature we use for Icelake-Server, which is
most likely wrong. The question is which one should be changed and to
what value? But most likely the Icelake-Server signature is wrong. We
copied it from QEMU, but I haven't seen a mention of any real
Icelake-Server CPU with such signature (or perhaps at all).

Anyway, it would be nice if we could add a test data (prior to this
patch) from host with Snowridge CPU to prove its signature is correct.

Jirka