[PATCH] NEWS: add note about virt-ssh-helper perf improvements

Andrea Bolognani abologna at redhat.com
Fri Nov 27 13:34:38 UTC 2020


On Fri, 2020-11-27 at 10:08 +0000, Daniel P. Berrangé wrote:
> +++ b/NEWS.rst
> @@ -44,6 +44,13 @@ v6.10.0 (unreleased)
>  
>  * **Bug fixes**
>  
> +  * remote: fixed performance regression in SSH tunnelling
> +
> +    The virt-ssh-helper binary introduced in 6.9.0 had very

virt-ssh-helper was introduced in 6.8.0, although detection was
broken in that version and so most people only ended up using it
starting with the next release.

You should also put double backticks around ``virt-ssh-helper``.

> +    poor scalability which impacted libvirt tunnelled migration
> +    and storage volume upload/download in particular. It has been
> +    updated and now has performance on a par with netcat.

I believe "on a par", while correct, is much less frequently used
than "on par" so it might look weird to non-native speakers - it
certainly did to me. You might want to change it to the more common
usage.

With at least the version number fixed,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list