[PATCH 1/1] vircommand.c: write child pidfile before process tuning in virExec()

[Michal Prívozník]

On 10/2/20 6:42 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 10/2/20 1:07 PM, Michal Prívozník wrote:
>> On 10/1/20 4:35 PM, Daniel Henrique Barboza wrote:
>>> When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent
> [...]
>>>
>>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1882093
>>>
>>> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>>> ---
>>>   src/util/vircommand.c | 19 ++++++++++---------
>>>   1 file changed, 10 insertions(+), 9 deletions(-)
>>
>> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
>>
>> And congratz onto gaining commit rights :-)
> 
> Thanks!
> 
> 
> By the way, we have a 'do not push stuff on Friday' rule to avoid breaking
> things during weekends, right? Guess I'll wait to push this one next 
> Monday.
> 

I'm not aware of any such rule. In fact, I've pushed couple of patches 
today already. I say, go ahead and push them! It doesn't break the build 
and if there is a subtle bug with a commit, I'm sure it can wait over 
the weekend anyway (I'm not picking on your commit in particular, just 
any commit - the sooner we test it the better).

Michal