[libvirt PATCH] tests: fix incorrect free of GVariant in our GLib mock functions

Cole Robinson crobinso at redhat.com
Sun Oct 4 17:05:57 UTC 2020

On 10/2/20 6:36 AM, Pavel Hrdina wrote:
> GLib implementation of g_dbus_connection_call_sync() calls
> g_variant_ref_sink() on the passed @parameters to make sure they have
> proper reference. If the original reference is floating the
> g_dbus_connection_call_sync() consumes it, but if it's normal reference
> it will just add another one.
> Our mock functions were only freeing the @parameters which is incorrect
> and doesn't reflect how the real implementation works.
> Reported-by: Cole Robinson <crobinso at redhat.com>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

I added this to Fedora and the build passed. Thanks!

- Cole

More information about the libvir-list mailing list