[libvirt PATCH 8/8] build: lower maximum frame size to 1792

Daniel P. Berrangé berrange at redhat.com
Mon Oct 5 08:12:46 UTC 2020


On Mon, Oct 05, 2020 at 12:21:45AM +0200, Ján Tomko wrote:
> This number is the closest multiple of 100000000

                                          ^^^ Huh ?

> above the largest frame value reported by clang
> in the current codebase.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  meson.build | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index a5ce8e17a8..8bef701f67 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -419,10 +419,9 @@ cc_flags += [
>    # but need to rewrite various areas of code first
>    '-Wno-format-truncation',
>  
> -  # This should be < 256 really. Currently we're down to 4096,
> -  # but using 1024 bytes sized buffers (mostly for virStrerror)
> -  # stops us from going down further
> -  '-Wframe-larger-than=4096',
> +  # This should be < 256 really.

I think we can drop this as I doubt it is worth trying to achieve.
We've not knowingly had stack overflow in livirt in history.

> +  # Using 1024 bytes sized buffers stops us from going down further
> +  '-Wframe-larger-than=1792',


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list