[PATCH] Support x-vga=on for PCI host passthrough devices

[Alex Williamson]

On Wed, 07 Oct 2020 14:20:21 +0100
Steven Newbury <steve at snewbury.org.uk> wrote:

> On Wed, 2020-10-07 at 15:07 +0200, Peter Krempa wrote:
> > On Wed, Oct 07, 2020 at 13:59:35 +0100, Steven Newbury wrote:  
> > > When using a passthrough GPU with libvirt there is no option to
> > > pass "x-vga=on" to the device specification.  This means legacy  
> > 
> > Please note that we don't add support for experimental qemu features
> > (prefixed with "x-") until they are deemed stable and the x- is
> > removed, so this patch can't be accepted in this form.
> >   
> Okay, so should I bug qemu to promote the feature to stable?  It's been
> like that forever, it's certainly not a new feature:
> 
> https://github.com/qemu/qemu/commit/f15689c7e4422d5453ae45628df5b83a53e518ed
> 
> So it's been that way for 8 years!

It's that way upstream because VGA routing is a nightmare, it's
essentially broken on any system with Intel graphics because the device
always has VGA regions routed to itself.  That problem is not getting
better, but the demand for VGA is getting less, so there's very little
incentive to work on the problem rather than just letting it die out
once nobody cares about VGA.  Any 600 series or newer GeForce card
should have a UEFI ROM available.  Also note that VGA support can be
configured both as a module option of vfio-pci and a build option, so
there's no guarantee that a display class device will have the VGA
regions available for QEMU to use this option.  Thanks,

Alex