[PATCH] tests: commandhelper: Accept POLLNVAL on macOS

[Roman Bolshakov]

On Wed, Oct 07, 2020 at 07:17:05PM +0200, Ján Tomko wrote:
> On a Wednesday in 2020, Roman Bolshakov wrote:

Hi Jano,

> 
> *indefinitely
> 
Thanks, I'll correct it.

> >  BUGS
> >    The poll() system call currently does not support devices.
> > 
> 
> Is there a bug that track this? If so, including it in a comment
> would help us delete this special case in distant future.
> 

Hi Jano,

Apple's poll() implementation was broken in many ways over the years,
but it's slowly getting better. Originally it wasn't able to deal even
with stdin [1] and supported only network sockets.

Also, there was a bug in macOS 10.12 [2] that was fixed in 10.12.2. And
gnustep has a test for the /dev/null bug [3]. Since [3] was done 11
years ago I haven't submitted a ticket for the issue but I'm surely can
do that and then I'd add a tag to commit message or a comment:

Apple-Feedback: FB<ISSUE NUMBER>

Would that work for you?

1. https://lists.apple.com/archives/darwin-dev/2006/Apr/msg00064.html
2. https://daniel.haxx.se/blog/2016/10/11/poll-on-mac-10-12-is-broken/
3. https://github.com/gnustep/libs-base/blob/master/config/config.poll-dev.c

Thanks,
Roman