[libvirt PATCH 05/15] meson: properly handle libpcap if it's explicitly disabled

Pavel Hrdina phrdina at redhat.com
Thu Oct 8 13:58:54 UTC 2020


If libpcap is detected using pkg-config it would ignore the libpcap
option.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 meson.build | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/meson.build b/meson.build
index 48d0d00288..0941be8136 100644
--- a/meson.build
+++ b/meson.build
@@ -1101,17 +1101,22 @@ if libparted_dep.found()
 endif
 
 libpcap_version = '1.5.0'
-libpcap_dep = dependency('libpcap', version: '>=' + libpcap_version, required: false)
-if not libpcap_dep.found()
-  pcap_config_prog = find_program('pcap-config', required: get_option('libpcap'))
-  if pcap_config_prog.found()
-    pcap_args = run_command(pcap_config_prog, '--cflags').stdout().strip().split()
-    pcap_libs = run_command(pcap_config_prog, '--libs').stdout().strip().split()
-    libpcap_dep = declare_dependency(
-      compile_args: pcap_args,
-      link_args: pcap_libs,
-    )
+if not get_option('libpcap').disabled()
+  libpcap_dep = dependency('libpcap', version: '>=' + libpcap_version, required: false)
+
+  if not libpcap_dep.found()
+    pcap_config_prog = find_program('pcap-config', required: get_option('libpcap'))
+    if pcap_config_prog.found()
+      pcap_args = run_command(pcap_config_prog, '--cflags').stdout().strip().split()
+      pcap_libs = run_command(pcap_config_prog, '--libs').stdout().strip().split()
+      libpcap_dep = declare_dependency(
+        compile_args: pcap_args,
+        link_args: pcap_libs,
+      )
+    endif
   endif
+else
+  libpcap_dep = dependency('', required: false)
 endif
 if libpcap_dep.found()
   conf.set('WITH_LIBPCAP', 1)
-- 
2.26.2




More information about the libvir-list mailing list