[libvirt PATCH 4/8] remote: remoteDispatchAuthList: remove useless 'rv'

Pavel Hrdina phrdina at redhat.com
Thu Oct 8 14:56:16 UTC 2020


On Thu, Oct 08, 2020 at 02:12:10PM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/remote/remote_daemon_dispatch.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
> index 90115167fb..b8813611c8 100644
> --- a/src/remote/remote_daemon_dispatch.c
> +++ b/src/remote/remote_daemon_dispatch.c
> @@ -3593,7 +3593,6 @@ remoteDispatchAuthList(virNetServerPtr server,
>                         virNetMessageErrorPtr rerr,
>                         remote_auth_list_ret *ret)
>  {
> -    int rv = -1;
>      int auth = virNetServerClientGetAuth(client);
>      uid_t callerUid;
>      gid_t callerGid;
> @@ -3636,11 +3635,7 @@ remoteDispatchAuthList(virNetServerPtr server,
>          break;
>      }
>  
> -    rv = 0;
> -
> -    if (rv < 0)
> -        virNetMessageSaveError(rerr);
> -    return rv;
> +    return 0;
>  }

../src/remote/remote_daemon_dispatch.c: In function ‘remoteDispatchAuthList’:
../src/remote/remote_daemon_dispatch.c:3593:46: error: unused parameter ‘rerr’ [-Werror=unused-parameter]
 3593 |                        virNetMessageErrorPtr rerr,
      |                        ~~~~~~~~~~~~~~~~~~~~~~^~~~
cc1: all warnings being treated as errors
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201008/8c714076/attachment-0001.sig>


More information about the libvir-list mailing list