[PATCH] the leading space in volmode check will never match the leading tab output from zfs get
Michal Privoznik
mprivozn at redhat.com
Fri Oct 9 07:15:05 UTC 2020
On 10/2/20 4:42 PM, Daniel Henrique Barboza wrote:
> The code is ok but the commit message can be improved. Usually
> we want a commit title with a single-line summary of what you're
> changing, a blank line, and a description describes in more
> the change, and your signed-off tag. This guideline can be
> found here:
>
> https://libvirt.org/best-practices.html
>
>
> For this patch, one possibility would be:
>
> -------
> storage_backend_zfs.c: remove leading space in volmode check
>
> The leading space in volmode check will never match the leading
> tab output from zfs get.
>
>
> Signed-off-by: Richard Burakowski <richard.burakowski at gmail.com>
> -------
>
>
Agree with Daniel here. Richard, can you please send v2 with the commit
message fixed? We can merge it then.
Michal
More information about the libvir-list
mailing list