[libvirt PATCH v2 5/9] spec: Introduce with_dmidecode

Andrea Bolognani abologna at redhat.com
Fri Oct 9 09:25:42 UTC 2020


To keep things maintainable, we want to have architecture handling
all in one spot instead of sprinkling %ifarch conditionals all over
the place.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
Reviewed-by: Neal Gompa <ngompa13 at gmail.com>
---
 libvirt.spec.in | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index d9fa27a5fe..ae6381fe3e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -94,6 +94,7 @@
 %define with_libssh2          0
 %define with_wireshark        0
 %define with_libssh           0
+%define with_dmidecode        0
 
 # Finally set the OS / architecture specific special cases
 
@@ -183,6 +184,10 @@
     %endif
 %endif
 
+%ifarch %{ix86} x86_64
+    %define with_dmidecode 0%{!?_without_dmidecode:1}
+%endif
+
 # Force QEMU to run as non-root
 %define qemu_user  qemu
 %define qemu_group  qemu
@@ -435,7 +440,7 @@ Requires: iproute-tc
 %endif
 
 Requires: polkit >= 0.112
-%ifarch %{ix86} x86_64
+%if %{with_dmidecode}
 # For virConnectGetSysinfo
 Requires: dmidecode
 %endif
-- 
2.26.2




More information about the libvir-list mailing list