[libvirt PATCH 09/15] meson: add rbd build option

[Pavel Hrdina]

On Thu, Oct 08, 2020 at 08:16:49PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-10-08 at 15:58 +0200, Pavel Hrdina wrote:
> > +++ b/meson_options.txt
> > @@ -31,6 +31,7 @@ option('numactl', type: 'feature', value: 'auto', description: 'numactl support'
> >  option('openwsman', type: 'feature', value: 'auto', description: 'openwsman support')
> >  option('pciaccess', type: 'feature', value: 'auto', description: 'pciaccess support')
> >  option('polkit', type: 'feature', value: 'auto', description: 'use PolicyKit for UNIX socket access checks')
> > +option('rbd', type: 'feature', value: 'auto', description: 'rbd support')
> 
> Shouldn't you add -Drbd=enabled to libvirt.spec.in now?

Actually there is no need to do that as %meson macro uses
--auto-features=%{__meson_auto_features} where the default value of
__meson_auto_features is enabled. So by default all auto features are
enabled.

But looking into the situation I'll drop the patch for now as it would
break RPM build in cases where we don't build storage_rbd as we wrap
build dependencies in a condition and we would have to do the same for
-Drbd as we do for -Dstorage_rbd which doesn't make sense.

I'll post a patch where we will reuse the storage_rbd option to figure
out if we need to check for rbd libs or not and the same should be
probably done for glusterfs and possibly some other libraries.

With autotools we had separate options for the library and for the
libvirt feature because we could pass a path to library but with meson
this is not possible. You can use --pkg-config-path meson option or
change env variables.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201009/0948e5b1/attachment-0001.sig>