[PATCH 0/2] qemu: Set noqueue qdisc for TAP devices

[Daniel Henrique Barboza]

On 10/8/20 3:10 PM, Michal Privoznik wrote:
> See 2/2 for detailed explanation.
> Long story short - we can squeeze more bandwidth from TAP devices we
> create for domains.
> 
> Michal Prívozník (2):
>    virnetdev: Introduce virNetDevSetRootQDisc()
>    qemu: Set noqueue qdisc for TAP devices


Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>


Have you tried it out with older kernels? Reading the bug I understood
that 4.2 and older (2015 kernels) does not have qdisc support and that you
can, for example, test for NETIF_F_LLTX of the ETHTOOL_GFEATURES ioctl to
verify it.

I consider this to be a 'nice to have' that can be added in a follow up
patch though, if applicable. By the way, do we have any documentation about
"the latest Libvirt release will not care about N+ years old kernel/QEMU"?


Thanks,

DHB




> 
>   src/libvirt_private.syms |  1 +
>   src/qemu/qemu_command.c  |  2 ++
>   src/qemu/qemu_domain.c   | 36 +++++++++++++++++++++++++++++++
>   src/qemu/qemu_domain.h   |  4 ++++
>   src/qemu/qemu_hotplug.c  |  2 ++
>   src/util/virnetdev.c     | 46 ++++++++++++++++++++++++++++++++++++++++
>   src/util/virnetdev.h     |  3 +++
>   7 files changed, 94 insertions(+)
>