[PATCH v2 4/7] hyperv: implement domainShutdown and domainShutdownFlags

Matt Coleman mcoleman at datto.com
Wed Oct 14 03:26:37 UTC 2020

> On Oct 13, 2020, at 3:55 AM, Pino Toscano <ptoscano at redhat.com> wrote:
> On Tuesday, 13 October 2020 07:14:01 CEST Matt Coleman wrote:
>> +    hypervAddSimpleParam(params, "Force", "False");
>> +    hypervAddSimpleParam(params, "Reason", _("Planned shutdown via libvirt"));
> Is this message logged in the Hyper-V logs? If so, then I'd not
> translate it: imagine an user running libvirt on an e.g. a French
> locale, sending this query to an Hyper-V on e.g. German. While English
> is not that different in this situation (still potentially not the
> Hyper-V language), at least IMHO it gives something understandable.
> Of course, in case the message is changed to an untranslated text,
> then please leave a comment there, so noone accidentally makes it
> translatable.

This text does get logged. I’ll remove the translation and add a comment.


More information about the libvir-list mailing list