[PATCH v1 11/24] qemu_command.c: reduce qemuBuildNicDevStr() if clauses

Michal Privoznik mprivozn at redhat.com
Thu Oct 15 11:46:51 UTC 2020


On 10/14/20 10:42 PM, Daniel Henrique Barboza wrote:
> We have a lot of "if (usingVirtio)" checks being done while
> constructing the NIC command line. Let's put all of them in
> a single "if".
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>   src/qemu/qemu_command.c | 50 ++++++++++++++++++++---------------------
>   1 file changed, 25 insertions(+), 25 deletions(-)

This is exactly what I wanted to suggest when looking at previous 
patches. Kudos!

Michal




More information about the libvir-list mailing list