[PATCH v2 6/7] hyperv: fix domainManagedSave on Hyper-V V2
Matt Coleman
mcoleman at datto.com
Sat Oct 17 20:32:01 UTC 2020
> On Oct 13, 2020, at 1:14 AM, Matt Coleman <mcoleman at datto.com> wrote:
>
> + if (priv->wmiVersion == HYPERV_WMI_VERSION_V2)
> + requestedState = MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE;
...
> + MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE = 6,
I realized I named this after the description of the (related)
Msvm_ComputerSystem EnabledState value, not the RequestStateChange()
method’s RequestedState parameter that this enum actually represents.
https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/msvm-computersystem#Enabled_but_Offline
https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/requeststatechange-msvm-computersystem#Offline
If another squashed change is ok, this should be
“MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_OFFLINE” instead of
“MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE”.
I feel like we’ve discussed a lot of changes getting squashed into this
patchset and that I should probably just revise it all and send v3.
--
Matt
More information about the libvir-list
mailing list