[PATCH] spec: Fix numad check

Andrea Bolognani abologna at redhat.com
Mon Oct 19 13:24:32 UTC 2020


On Mon, 2020-10-19 at 14:23 +0200, Boris Fiuczynski wrote:
> Fixes commit 974dc0a4c678af8ccb9224abecc834bb593e81fa
> which caused
> 
> DEBUG: meson.build:2149:2: ERROR: Problem encountered: You must have numactl enabled for numad support.
> 
> on s390x.
> 
> Signed-off-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
> Reviewed-by: Marc Hartmayer <mhartmay at linux.ibm.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 2bd4784d0f..325566f329 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -182,7 +182,7 @@
>  %if %{with_qemu} || %{with_lxc}
>  # numad is used to manage the CPU and memory placement dynamically,
>  # it's not available on many non-x86 architectures.
> -    %ifnarch %{arches_numad}
> +    %ifarch %{arches_numad}
>          %define with_numad    0%{!?_without_numad:1}
>      %endif
>  %endif

Good catch! I'll turn the initial sentence in the commit message into
a proper Fixes: tag, add my

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

and push.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list