[PATCH v2 1/2] qemuxml2argvtest: Sanitize testing of '-enable-fips'

Daniel P. Berrangé berrange at redhat.com
Wed Oct 21 08:52:37 UTC 2020


On Wed, Oct 21, 2020 at 10:35:26AM +0200, Peter Krempa wrote:
> Rename 'FLAG_FIPS' to 'FLAG_FIPS_HOST' to signify that we are simulating
> a host supporting fips mode and use the flag to assert 'enabeFips'
> argument of 'qemuProcessCreatePretendCmdBuild' rather than passing it
> via QEMU_CAPS_ENABLE_FIPS.
> 
> This prepares the testsuite for testing of -enable-fips deprecation in
> qemu-5.2.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  tests/qemuxml2argvdata/fips-enabled.args      | 31 --------------
>  .../fips-enabled.x86_64-5.1.0.args            | 40 ++++++++++++++++++
>  .../fips-enabled.x86_64-latest.args           | 41 +++++++++++++++++++
>  tests/qemuxml2argvtest.c                      | 11 +++--
>  tests/testutilsqemu.h                         |  2 +-
>  5 files changed, 87 insertions(+), 38 deletions(-)
>  delete mode 100644 tests/qemuxml2argvdata/fips-enabled.args
>  create mode 100644 tests/qemuxml2argvdata/fips-enabled.x86_64-5.1.0.args
>  create mode 100644 tests/qemuxml2argvdata/fips-enabled.x86_64-latest.args

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list